GlobalSchema is not longer global: update the name to represent that …

…and not export it

lib/format/pgsql8/diff.go

@@ -376,7 +376,7 @@ func (d *diff) updatePermissions(stage1 output.OutputFileSegmenter, stage3 outpu
 		}
 		for _, newGrant := range newSchema.Grants {
 			if oldSchema == nil || !ir.HasPermissionsOf(oldSchema, newGrant, ir.SqlFormatPgsql8) {
-				s, err := GlobalSchema.GetGrantSql(d.ops.dbsteward, newDoc, newSchema, newGrant)
+				s, err := commonSchema.GetGrantSql(d.ops.dbsteward, newDoc, newSchema, newGrant)
 				if err != nil {
 					return err
 				}
@@ -509,13 +509,13 @@ func (d *diff) updateData(ofs output.OutputFileSegmenter, deleteMode bool) error
 // DropSchemaSQL this implementation is a bit hacky as it's a
 // transitional step as I factor away global variables
 func (d *diff) DropSchemaSQL(s *ir.Schema) ([]output.ToSql, error) {
-	return GlobalSchema.GetDropSql(s), nil
+	return commonSchema.GetDropSql(s), nil
 }
 
 // CreateSchemaSQL this implementation is a bit hacky as it's a
 // transitional step as I factor away global variables
 func (d *diff) CreateSchemaSQL(s *ir.Schema) ([]output.ToSql, error) {
-	return GlobalSchema.GetCreationSql(d.ops.dbsteward, s)
+	return commonSchema.GetCreationSql(d.ops.dbsteward, s)
 }
 
 func (diff *diff) DiffDoc(oldFile, newFile string, oldDoc, newDoc *ir.Definition, upgradePrefix string) error {

lib/format/pgsql8/diff_types.go

@@ -33,7 +33,7 @@ func diffTypes(dbs *lib.DBSteward, differ *diff, ofs output.OutputFileSegmenter,
 		}
 
 		// TODO(feat) what about functions in other schemas?
-		for _, oldFunc := range GlobalSchema.GetFunctionsDependingOnType(oldSchema, oldType) {
+		for _, oldFunc := range commonSchema.GetFunctionsDependingOnType(oldSchema, oldType) {
 			ofs.WriteSql(sql.NewComment(
 				"Type migration of %s.%s requires recreating dependent function %s.%s",
 				newSchema.Name, newType.Name, oldSchema.Name, oldFunc.Name,
@@ -62,7 +62,7 @@ func diffTypes(dbs *lib.DBSteward, differ *diff, ofs output.OutputFileSegmenter,
 		}
 
 		// functions are only recreated if they changed elsewise, so need to create them here
-		for _, newFunc := range GlobalSchema.GetFunctionsDependingOnType(newSchema, newType) {
+		for _, newFunc := range commonSchema.GetFunctionsDependingOnType(newSchema, newType) {
 			s, err := getFunctionCreationSql(dbs, newSchema, newFunc)
 			if err != nil {
 				return err

lib/format/pgsql8/operations.go

@@ -957,15 +957,15 @@ func (ops *Operations) buildSchema(doc *ir.Definition, ofs output.OutputFileSegm
 	// TODO(go,3) roll this into diffing nil -> doc
 	// schema creation
 	for _, schema := range doc.Schemas {
-		s, err := GlobalSchema.GetCreationSql(ops.dbsteward, schema)
+		s, err := commonSchema.GetCreationSql(ops.dbsteward, schema)
 		if err != nil {
 			return err
 		}
 		ofs.WriteSql(s...)
 
 		// schema grants
 		for _, grant := range schema.Grants {
-			s, err := GlobalSchema.GetGrantSql(ops.dbsteward, doc, schema, grant)
+			s, err := commonSchema.GetGrantSql(ops.dbsteward, doc, schema, grant)
 			if err != nil {
 				return err
 			}

lib/format/pgsql8/pgsql8.go

@@ -5,7 +5,7 @@ import (
 	"github.com/dbsteward/dbsteward/lib/ir"
 )
 
-var GlobalSchema = NewSchema()
+var commonSchema = NewSchema()
 
 func init() {
 	lib.RegisterFormat(ir.SqlFormatPgsql8, NewOperations)