Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to the pipeline before pushing the image #22

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Conversation

Morl99
Copy link
Contributor

@Morl99 Morl99 commented Nov 15, 2024

closes #21

@Morl99 Morl99 force-pushed the 21-automatic-test branch 4 times, most recently from 39c32e7 to 9ed5b9d Compare November 18, 2024 13:05
@Morl99 Morl99 force-pushed the 21-automatic-test branch 2 times, most recently from 13cced5 to bc8aae5 Compare November 18, 2024 13:27
@Morl99
Copy link
Contributor Author

Morl99 commented Nov 18, 2024

@jschirrmacher do you care to review this change? I have managed to find a way to test the image within the action before pushing it. We really only know if this works once we have merged, since there are steps in the workflow that only run on main.

@jschirrmacher
Copy link
Contributor

jschirrmacher commented Nov 18, 2024

So now you create and push a docker image in any case, just with different tags, right?
Apart from the number of images that are created, I have no concerns.

@Morl99
Copy link
Contributor Author

Morl99 commented Nov 18, 2024

Actually, the number of images (or rather layers) is unchanged, unless we actually have a faulty image. The retagged images are unchanged compared to the first one.

Thanks for looking over it. Using the registry was the only way possible, since docker cannot locally load multi architecture images built with buildx.

@Morl99 Morl99 merged commit 088a2c4 into main Nov 18, 2024
7 checks passed
@Morl99 Morl99 deleted the 21-automatic-test branch November 18, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Docker image before pipeline within GitHub Action
2 participants