Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changie/changelog/view action #193

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented May 3, 2024

Description

View changie changelog given a version (.changes/<version>.md not CHANGELOG.md)

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue

- name: "Get changelog"
id: changelog
shell: bash
run: ./changie/changelog/view/get_changelog.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action is really just a wrapper for the bash script at this point. Why not just call call the bash script in a workflow/action/where ever you need it?

Comment on lines +26 to +30
- name: "Parse version: `${{ inputs.version }}`"
id: version
uses: ./parse-semver
with:
version: ${{ inputs.version }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we end up parsing the version in many of these actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants