refactor gha to resuse across multiple actions #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmyoop
requested changes
Jun 20, 2024
There was a problem hiding this comment.
I think this should be a composite action instead of a workflow.
There was a problem hiding this comment.
Sorry just got to this, is there a reason composite action is better for this?
Based on what I saw: Resusable workflow has more detailed logging, and can have multiple jobs(which we don't need here).
https://dev.to/n3wt0n/github-composite-actions-vs-reusable-workflows-updated-2023-bl8
| pull-requests: write | ||
|
|
||
| jobs: | ||
| changelog_existence: |
There was a problem hiding this comment.
All references to changelog should be updated to be "path" or something similar since this is now more generalized.
Comment on lines
+18
to
+23
| # changelog: | ||
| # uses: dbt-labs/actions/.github/workflows/changelog-check.yml@main | ||
| # with: | ||
| # changelog_comment: 'Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see [the contributing guide](https://github.com/dbt-labs/dbt-core/blob/main/CONTRIBUTING.md#adding-changelog-entry).' | ||
| # path: '.changes/unreleased/**.yaml' | ||
| # secrets: inherit # this is only acceptable because we own the action we're calling |
There was a problem hiding this comment.
Once this is an action this will need to be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #dbt-core/10329
Description
Checklist