-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macro to allow adapter-specific choice of unspecified value #263
base: main
Are you sure you want to change the base?
Add macro to allow adapter-specific choice of unspecified value #263
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @steffen030 |
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @steffen030 |
Should be signed now. |
Hi @colin-rogers-dbt , any news on this PR? I would really like to see unit tests becoming useable with Clickhouse. |
dbt/include/global_project/macros/relations/column/columns_spec_ddl.sql
Outdated
Show resolved
Hide resolved
dbt/include/global_project/macros/unit_test_sql/get_fixture_sql.sql
Outdated
Show resolved
Hide resolved
Co-authored-by: Colin Rogers <[email protected]>
The current implementation of unit tests renders
null
values for unspecified columns. This however is problematic for databases like Clickhouse which know not-nullable datatypes. For these cases unit tests are currently not working.This PR allows database adapters to override the unspecified column value.
It closes dbt-labs/dbt-core#10447