-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow use of multiple column unique keys in snapshots #326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few suggestions focusing on minimizing the amount of jinja that we have and making that jinja more readable. Let me know what you think.
dbt/include/global_project/macros/materializations/snapshots/helpers.sql
Outdated
Show resolved
Hide resolved
dbt/include/global_project/macros/materializations/snapshots/helpers.sql
Outdated
Show resolved
Hide resolved
dbt/include/global_project/macros/materializations/snapshots/strategies.sql
Outdated
Show resolved
Hide resolved
dbt/include/global_project/macros/materializations/snapshots/strategies.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every time we remove jinja, an angel gets its wings.
resolves #181
Problem
Implement use of a list for a unique_key in snapshots
Solution
Check whether the unique_key is a list and modify the SQL.
Checklist