Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAP-1124: Establish shared workflows for the monorepo migration #362

Merged
merged 66 commits into from
Dec 10, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Nov 22, 2024

Problem

We're moving to a monorepo for adapters. This will require workflows that can be reused across adapters.

Solution

Migrate workflows from dbt-athena, which is already technically a monorepo (two packages) and make updates as needed to generalize. Update the workflows to support dbt-adapters and dbt-tests-adapter in the short term until their folder structures are updated, and then remove any existing workflows which are no longer necessary. Use this refactor as an opportunity to also clean up existing workflows which will live on in the monorepo.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Nov 22, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@mikealfare mikealfare marked this pull request as ready for review December 5, 2024 10:21
@mikealfare mikealfare requested a review from a team as a code owner December 5, 2024 10:21
@mikealfare
Copy link
Contributor Author

Successful atomic workflow runs:

I can't validate _changelog-entry-check because the action we use inspects the trigger method to run.
I can't validate _publish-internal because we don't publish dbt-adapters internally yet.
I added pull_request as a trigger and confirmed that changelog entry check, unit tests, code quality, and build verification checks ran as expected.

@mikealfare mikealfare merged commit fb11e9f into main Dec 10, 2024
4 checks passed
@mikealfare mikealfare deleted the monorepo/shared-workflows branch December 10, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants