-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a new incremental_substrategy
for insert_overwrite
and microbatch
#1415
Open
borjavb
wants to merge
13
commits into
dbt-labs:main
Choose a base branch
from
borjavb:insert-overwrite-opt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borjavb
changed the title
Draft test
Draft example of insert_overwrite with a new sub optimization function
Nov 28, 2024
borjavb
force-pushed
the
insert-overwrite-opt
branch
6 times, most recently
from
December 30, 2024 09:31
25e45c7
to
16be393
Compare
fixtures Create Features-20241229-174752.yaml
borjavb
force-pushed
the
insert-overwrite-opt
branch
2 times, most recently
from
December 30, 2024 12:31
6580895
to
d2e321a
Compare
borjavb
changed the title
Draft example of insert_overwrite with a new sub optimization function
Create a new Dec 31, 2024
incremental_substrategy
for insert_overwrite
and microbatch
borjavb
force-pushed
the
insert-overwrite-opt
branch
from
January 17, 2025 19:36
d2e321a
to
5893789
Compare
borjavb
force-pushed
the
insert-overwrite-opt
branch
from
January 24, 2025 10:54
06baa78
to
241119a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves dbt-labs/dbt-adapters#527
docs dbt-labs/docs.getdbt.com/#
Problem
By default, we are using a
MERGE
operation when running aninsert_overwrite
ormicrobatch
operation. But this is not the most performant solution. In fact, we have different options with their pros and cons. Currently we only rely onmerge
that is not the best performant solution and it doesn't allow fully parallelism formicrobatch
operations.Solution
In this PR we propose adding a new
incremental_substrategy
formicrobatch
andinsert_overwrite
that will allow the user to select the best logic based on their needs.Additionally, based on experience the best combo I've seen is:
For that reason, we can add an additional
optimised
option that will run the best operation available (and that can be updated in the future if needed)We could force every user to use the
optimised
by default with the new release, but I just feel unease given thatmerge
has been the default for ever and people might have built logics assuming this behaviour...?Checklist