-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: catch jinja typeerrors during render phase #207
base: main
Are you sure you want to change the base?
fix: catch jinja typeerrors during render phase #207
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
==========================================
- Coverage 68.48% 68.42% -0.07%
==========================================
Files 52 52
Lines 3389 3401 +12
==========================================
+ Hits 2321 2327 +6
- Misses 1068 1074 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Can you add a unit test? It's not always possible, but its preferable. Also you need to run |
Yes, I can! I was just waiting for approval before spending time coding without knowing if the dbt-core team wanted that. |
Done @gshank But it seems there are other issues not related with this PR
|
Hey @peterallenwebb , Would you mind taking a look at this PR? |
resolves #206
Description
After this, a TypeError in render phase will show the node information
Checklist
changie new
to create a changelog entry