-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catch generic exception in catch_jinja and reraise as CompilationError #224
base: main
Are you sure you want to change the base?
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
==========================================
- Coverage 68.50% 68.42% -0.09%
==========================================
Files 52 52
Lines 3391 3395 +4
==========================================
Hits 2323 2323
- Misses 1068 1072 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
For good measure, running dbt-core tests here before merging |
Re-running dbt-core tests here: https://github.com/dbt-labs/dbt-core/actions/runs/12122320481?pr=11085 |
resolves #225
Description
Catch generic
Exception
and re-raise as compilation error with node context for improved user. debugging experience.Checklist
changie new
to create a changelog entry🎩