Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TESTING] Er/unpin 18 #11022

Closed
wants to merge 2 commits into from
Closed

[TESTING] Er/unpin 18 #11022

wants to merge 2 commits into from

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Nov 21, 2024

Resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@emmyoop emmyoop changed the base branch from main to 1.8.latest November 21, 2024 16:36
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@emmyoop emmyoop closed this Nov 21, 2024
@emmyoop emmyoop reopened this Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.32%. Comparing base (3a1c605) to head (fc1d318).

Additional details and impacted files
@@              Coverage Diff               @@
##           1.8.latest   #11022      +/-   ##
==============================================
- Coverage       88.33%   88.32%   -0.01%     
==============================================
  Files             181      181              
  Lines           22796    22796              
==============================================
- Hits            20136    20134       -2     
- Misses           2660     2662       +2     
Flag Coverage Δ
integration 85.58% <ø> (-0.01%) ⬇️
unit 62.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@emmyoop emmyoop closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant