Snowflake: Add expression parameter to columns #209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for an optional `expression` key given under `column`.
When given, column.expression is passed to `{{column_quoted}} {{column.data_type}} as ({{col_expression}}::{{column.data_type}})` instead of
```{%- set col_id = 'value:c' ~ loop.index if is_csv else 'value:' ~ column_quoted -%}
(case when is_null_value({{col_id}}) or lower({{col_id}}) = 'null' then null else {{col_id}} end)
```
|
This would be such a great addition! |
|
We are eagerly awaiting this PR. This will fix the issue when a source field is named |
|
@jeremyyeo, any update on this? |
|
Hey folks - we'll try to get this merged this week. |
|
Any update on this? we would really love to have this feature included in the package |
|
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days. |
|
yes, what is the hesitation to merging this? |
|
are there plans to add tests for this pr? |
|
@jeremyyeo is there any update on merging this? |
3 tasks
|
closing in favor of #275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
resolves: #140
Checklist