-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snowflake: Add expression parameter to columns #275
Conversation
…xternal_table.sql and snowflake.yml
depending on the order of the merges, we will have to resolve conflicts with #257 , i am adding column alias functionality there. |
@dataders is there something preventing this PR from being merged? |
+1 |
integration_tests/models/plugins/snowflake/snowflake_external.yml
Outdated
Show resolved
Hide resolved
integration_tests/models/plugins/snowflake/snowflake_external.yml
Outdated
Show resolved
Hide resolved
integration_tests/models/plugins/snowflake/snowflake_external.yml
Outdated
Show resolved
Hide resolved
…f people_csv_expression
@kyleburke-meq thanks for resolving the conflicts and adding the integration test for the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @kyleburke-meq (and @jpear3)!
{%- set column_quoted = adapter.quote(column.name) if column.quote else column.name %} | ||
{%- set column_alias -%} | ||
{%- if 'alias' in column and column.quote -%} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change introduced the bug - #315
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is a bug. left a reply in that issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah actually I think I see the issue now. We should be using column_quoted
instead of column_alias
here I think?:
{%- set col_id = 'value:c' ~ loop.index if is_csv else 'value:' ~ column_alias -%} |
resolves: #140
Adds the ability for custom expressions and identifiers to external sources in snowflake.
Description & motivation
All credit goes to @ipear3 and his original PR: #209
I am just resolving a merge conflict and want to see the code implemented.
Checklist