Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alias column for snowflake external table #257

Merged
merged 6 commits into from
Apr 11, 2024
Merged

alias column for snowflake external table #257

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
63d14c1
alias column for snowflake external table
cakkinep Feb 26, 2024
60fce28
Merge branch 'main' into snowflake_column_alias
dataders Apr 5, 2024
0460d59
added column alias test
cakkinep Apr 11, 2024
91e80c7
adding integration test for alias column
cakkinep Apr 11, 2024
9b4cbdf
Merge branch 'main' into snowflake_column_alias
dataders Apr 11, 2024
954733a
Merge branch 'main' into snowflake_column_alias
dataders Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion macros/plugins/snowflake/create_external_table.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,14 @@
{%- endfor -%}{%- endif -%}
{%- if not infer_schema -%}
{%- for column in columns %}
{%- set column_alias = column.alias if column.alias else column.name %}
{%- set column_alias_quoted = adapter.quote(column_alias) if column.quote else column_alias %}
{%- set column_quoted = adapter.quote(column.name) if column.quote else column.name %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line needed or used anymore?

Suggested change
{%- set column_quoted = adapter.quote(column.name) if column.quote else column.name %}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is needed as the column_quoted is used in the expression part of the definition, we can't use column_alias_quoted in value: , hope that clarifies the need.

{%- set col_expression -%}
{%- set col_id = 'value:c' ~ loop.index if is_csv else 'value:' ~ column_quoted -%}
(case when is_null_value({{col_id}}) or lower({{col_id}}) = 'null' then null else {{col_id}} end)
{%- endset %}
{{column_quoted}} {{column.data_type}} as ({{col_expression}}::{{column.data_type}})
{{column_alias_quoted}} {{column.data_type}} as ({{col_expression}}::{{column.data_type}})
{{- ',' if not loop.last -}}
{% endfor %}
{% else %}
Expand Down
Loading