Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Er/tox #513

Merged
merged 7 commits into from
Nov 13, 2024
Merged

Er/tox #513

merged 7 commits into from
Nov 13, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Nov 13, 2024

This is a:

  • bug fix PR with no breaking changes
  • new functionality

Link to Issue

Description & motivation

Integration Test Screenshot

Checklist

  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
    • Databricks
    • DuckDB
    • Trino/Starburst
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@emmyoop emmyoop changed the base branch from main to tox November 13, 2024 17:30
@emmyoop emmyoop marked this pull request as ready for review November 13, 2024 18:16
@dave-connors-3 dave-connors-3 merged commit 0f94b8b into tox Nov 13, 2024
12 of 15 checks passed
@dave-connors-3 dave-connors-3 deleted the er/tox branch November 13, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dave-connors-3 dave-connors-3 dave-connors-3 approved these changes

@graciegoheen graciegoheen Awaiting requested review from graciegoheen

@b-per b-per Awaiting requested review from b-per

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmyoop @dave-connors-3