Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to dbt Explorer #4537

Merged
merged 16 commits into from
Nov 28, 2023
Merged

Updates to dbt Explorer #4537

merged 16 commits into from
Nov 28, 2023

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Nov 27, 2023 •
edited
Loading

What are you changing in this pull request and why?

Updates to dbt Explorer

Checklist

Adding new pages (delete if not applicable):

  • [ ] Add page to website/sidebars.js n/a for release notes
  • Provide a unique filename for the new page

@vercel Vercel
Copy link

vercel bot commented Nov 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com 🛑 Canceled (Inspect) Nov 28, 2023 3:11pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address and removed auto update Docs team Authored by the Docs team @dbt Labs labels Nov 27, 2023
dave-connors-3
dave-connors-3 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@dave-connors-3 dave-connors-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦞 LGTM with those two removals we chatted about!

cafzal
cafzal requested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@cafzal cafzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits to release notes

website/docs/docs/dbt-versions/release-notes/02-Nov-2023/explorer-updates-rn.md Outdated Show resolved Hide resolved
website/docs/docs/dbt-versions/release-notes/02-Nov-2023/explorer-updates-rn.md Outdated Show resolved Hide resolved
website/docs/docs/dbt-versions/release-notes/02-Nov-2023/explorer-updates-rn.md Outdated Show resolved Hide resolved
website/docs/docs/dbt-versions/release-notes/02-Nov-2023/explorer-updates-rn.md Outdated Show resolved Hide resolved
website/docs/docs/dbt-versions/release-notes/02-Nov-2023/explorer-updates-rn.md Outdated Show resolved Hide resolved
website/docs/docs/dbt-versions/release-notes/02-Nov-2023/explorer-updates-rn.md Outdated Show resolved Hide resolved
website/docs/docs/dbt-versions/release-notes/02-Nov-2023/explorer-updates-rn.md Outdated Show resolved Hide resolved
website/docs/docs/dbt-versions/release-notes/02-Nov-2023/explorer-updates-rn.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Docs team Authored by the Docs team @dbt Labs label Nov 28, 2023
@nghi-ly nghi-ly marked this pull request as ready for review November 28, 2023 00:29
@nghi-ly nghi-ly requested a review from a team as a code owner November 28, 2023 00:29
@nghi-ly nghi-ly requested a review from cafzal November 28, 2023 00:32
cafzal
cafzal approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@cafzal cafzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

mirnawong1
mirnawong1 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions so content is easier to read and fixing some links up too

@mirnawong1
Copy link
Contributor

hey @nghi-ly and @cafzal - committed the changes, especially the links, and will merge this now

@mirnawong1 mirnawong1 merged commit bcbab8a into current Nov 28, 2023
7 checks passed
@mirnawong1 mirnawong1 deleted the ly-docs-explorer-update branch November 28, 2023 15:11
mirnawong1
mirnawong1 reviewed Nov 28, 2023
View reviewed changes
website/docs/docs/dbt-versions/release-notes/02-Nov-2023/explorer-updates-rn.md
sidebar_label: "Enhancement: New features and UI changes to dbt Explorer"
sidebar_position: 08
tags: [Nov-2023]
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the date property was missed! might be good to post in the dbt cloud community channel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great flag! will update in a fast-follow pr, tysm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

@dave-connors-3 dave-connors-3 dave-connors-3 approved these changes

@cafzal cafzal cafzal approved these changes

Assignees
No one assigned
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nghi-ly @mirnawong1 @cafzal @dave-connors-3