Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing limitation bullet #4549

Merged
merged 4 commits into from
Nov 29, 2023
Merged

removing limitation bullet #4549

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bcccc1d
removing limitation bullet
mirnawong1 Nov 29, 2023
0429a61
Merge branch 'current' into mirnawong1-patch-22
mirnawong1 Nov 29, 2023
09ccb02
Update website/docs/docs/build/cumulative-metrics.md
mirnawong1 Nov 29, 2023
50d3a64
Merge branch 'current' into mirnawong1-patch-22
mirnawong1 Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions website/docs/docs/build/cumulative-metrics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,7 @@ metrics:

## Limitations
Cumulative metrics are currently under active development and have the following limitations:

1. You can only use the [`metric_time` dimension](/docs/build/dimensions#time) to check cumulative metrics. If you don't use `metric_time` in the query, the cumulative metric will return incorrect results because it won't perform the time spine join. This means you cannot reference time dimensions other than the `metric_time` in the query.
2. If you use `metric_time` in your query filter but don't include "start_time" and "end_time," cumulative metrics will left-censor the input data. For example, if you query a cumulative metric with a 7-day window with the filter `{{ TimeDimension('metric_time') }} BETWEEN '2023-08-15' AND '2023-08-30' `, the values for `2023-08-15` to `2023-08-20` return missing or incomplete data. This is because we apply the `metric_time` filter to the aggregation input. To avoid this, you must use `start_time` and `end_time` in the query filter.

- You can only use the [`metric_time` dimension](/docs/build/dimensions#time) to check cumulative metrics. If you don't use `metric_time` in the query, the cumulative metric will return incorrect results because it won't perform the time spine join. This means you cannot reference time dimensions other than the `metric_time` in the query.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can only use the metric_time dimension to check

I would re-phrase this too "You are required to use metric_time when querying cumulative metrics"

mirnawong1 marked this conversation as resolved.
Show resolved Hide resolved

## Cumulative metrics example

Expand Down
Loading