Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update model-query-history.md #6525

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

wusanny
Copy link
Contributor

@wusanny wusanny commented Nov 22, 2024

Following the change by Jimmy (thank you!) - customer mentioned that while it is great documentation now reflects the minimum tier requirement in Snowflake - they felt it "is kinda buried".

The only improvement I can think of is to bold it.

What are you changing in this pull request and why?

Slack discussion

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

Following the change by Jimmy (thank you!) - customer mentioned that while it is great documentation now reflects the minimum tier requirement in Snowflake - they felt it "is kinda buried". 

The only improvement I can think of is to bold it.
@wusanny wusanny requested a review from a team as a code owner November 22, 2024 09:10
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Nov 22, 2024 2:13pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Nov 22, 2024
@mirnawong1
Copy link
Contributor

thanks for openign this up @wusanny ! I'll see if we can make this more prominent and add it as a callout or something

@mirnawong1
Copy link
Contributor

mirnawong1 commented Nov 22, 2024

ok made this change here so it's a callout and more visual (cc @jzhu13 ) :

Screenshot 2024-11-22 at 09 08 13

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Nov 22, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much again for opening this up @wusanny -- great addition and i loved working together to improve this section. hopefully the callout is a bit clearer now but let me know if this is still confusing users!

@mirnawong1 mirnawong1 merged commit 2371954 into current Nov 22, 2024
8 of 9 checks passed
@mirnawong1 mirnawong1 deleted the wusanny-edit-model-query-history-docs branch November 22, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants