-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource-config pages for microbatch configs #6575
base: current
Are you sure you want to change the base?
Add resource-config pages for microbatch configs #6575
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
datatype: hour | day | month | year | ||
--- | ||
|
||
Available in dbt Cloud Versionless and dbt Core v1.9 and higher. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be ok if we version the whole page? Any issues with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no issue with that. The only reason I didn't was because I directly copied and then edited the event_time.md
page
|
||
<Tabs> | ||
|
||
<TabItem value="model" label="Models"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@QMalcolm Do we consider this a "work in progress"? There's a single tab item in this section. Should each example be a tab?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More tabs are not expected. I just didn't know what the format should be if it's only applicable to Models
, should it just be a sub heading instead?
@QMalcolm The new pages are not on the sidebar. Was that intentional? If not, I am happy to add them. |
…icrobatch-configs
Co-authored-by: Matt Shaver <[email protected]>
Co-authored-by: Matt Shaver <[email protected]>
Co-authored-by: Matt Shaver <[email protected]>
Co-authored-by: Matt Shaver <[email protected]>
Co-authored-by: Matt Shaver <[email protected]>
Co-authored-by: Matt Shaver <[email protected]>
Co-authored-by: Matt Shaver <[email protected]>
@matthewshaver This was not intentional, we should add them |
Co-authored-by: Matt Shaver <[email protected]>
Co-authored-by: Matt Shaver <[email protected]>
Co-authored-by: Matt Shaver <[email protected]>
Co-authored-by: Matt Shaver <[email protected]>
Co-authored-by: Matt Shaver <[email protected]>
What are you changing in this pull request and why?
We had resource config page for
event_time
but not,begin
,lookback
, orbatch_size
(which are all configs for microbatch incremental models). This seemed like a gap. As such, I've added pages forbegin
,lookback
, andbatch_size
and also linked them in the incremental-microbatch page.Checklist