Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource-config pages for microbatch configs #6575

Open
wants to merge 17 commits into
base: current
Choose a base branch
from

Conversation

QMalcolm
Copy link
Contributor

@QMalcolm QMalcolm commented Dec 2, 2024

What are you changing in this pull request and why?

We had resource config page for event_time but not, begin, lookback, or batch_size (which are all configs for microbatch incremental models). This seemed like a gap. As such, I've added pages for begin, lookback, and batch_size and also linked them in the incremental-microbatch page.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

@QMalcolm QMalcolm requested a review from a team as a code owner December 2, 2024 22:11
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com 🛑 Canceled (Inspect) Dec 3, 2024 9:44pm

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address labels Dec 2, 2024
datatype: hour | day | month | year
---

Available in dbt Cloud Versionless and dbt Core v1.9 and higher.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be ok if we version the whole page? Any issues with that?

Copy link
Contributor Author

@QMalcolm QMalcolm Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no issue with that. The only reason I didn't was because I directly copied and then edited the event_time.md page


<Tabs>

<TabItem value="model" label="Models">
Copy link
Contributor

@matthewshaver matthewshaver Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QMalcolm Do we consider this a "work in progress"? There's a single tab item in this section. Should each example be a tab?

Screenshot 2024-12-03 at 12 11 52 AM

Copy link
Contributor Author

@QMalcolm QMalcolm Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More tabs are not expected. I just didn't know what the format should be if it's only applicable to Models, should it just be a sub heading instead?

@matthewshaver
Copy link
Contributor

@QMalcolm The new pages are not on the sidebar. Was that intentional? If not, I am happy to add them.

@QMalcolm
Copy link
Contributor Author

QMalcolm commented Dec 3, 2024

@QMalcolm The new pages are not on the sidebar. Was that intentional? If not, I am happy to add them.

@matthewshaver This was not intentional, we should add them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants