Update url paths to use old route #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
john-rock
changed the title
JKarlavige
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
lgtm! Opened an old deploy preview before the upgrade and verified all sidebar routes match what is in this preview.
🚢
leighstaub
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the PR that contained the docusaurs upgrade was merged Leigh noticed the URLs that were linked in notion were broken.
e.g.
https://handbook.getdbt.com/docs/benefits#healthcare-benefits-us
https://handbook.getdbt.com/docs/time_off
This PR updates the
routeBasePathto use what we previously had making the links work again.https://handbook-getdbt-com-git-update-url-paths-dbt-labs.vercel.app/docs/benefits#healthcare-benefits-us
https://handbook-getdbt-com-git-update-url-paths-dbt-labs.vercel.app/docs/time_off