Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to the latest decorators API #78

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oleavr
Copy link
Contributor

@oleavr oleavr commented May 18, 2021

(Not sure if this is of interest, but wanted to share just in case. Only the method decorator has been tested so far.)

@acrisci
Copy link
Member

acrisci commented May 20, 2021

Can you provide details of the decorator api you are using? And is this a breaking change?

@oleavr
Copy link
Contributor Author

oleavr commented Jul 9, 2021

Oops, sorry, it's been a while since I did this so I can't remember where I read the spec. But what I do know is that this matches what the latest Babel 7 plugin expects. This is a breaking change, unfortunately.

@acrisci
Copy link
Member

acrisci commented Jul 9, 2021

If it's going to be breaking, I think I want to wait for the proposal to reach stage 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants