Conway cert builder support #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support for adding conway certs to txs with support for deposit calculation also fixes NetworkId bug
gostkin
reviewed
Oct 24, 2023
| Certificate::RegCert(_cert) => todo!(), | ||
| Certificate::RegCert(_cert) => { | ||
| // does not require a witness | ||
| } | ||
| Certificate::UnregCert(_cert) => todo!(), |
There was a problem hiding this comment.
Forgot to add them here too. The ones in cert_required_wits were all tested so this should be fine since it's based on those and identical except it errors when the wits aren't vkeys. I just pushed a commit that includes these too.
gostkin
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support for adding conway certs to txs with support for deposit calculation
also fixes NetworkId bug