Prefix CIP25/CIP36 types #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gostkin
approved these changes
Nov 14, 2023
Many CIP25/CIP36 types were pretty confusing when used from WASM as there was no module scoping so everything was put together in the same scope as chain/etc so things like "Delegation" were not obviously CIP36 for example. We now prefix all types in both crates with CIP25/CIP36 to help with this.
gostkin
force-pushed
the
cip25-cip36-prefixes
branch
from
de9a5b4 to
a7bcc71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many CIP25/CIP36 types were pretty confusing when used from WASM as there was no module scoping so everything was put together in the same scope as chain/etc so things like "Delegation" were not obviously CIP36 for example.
We now prefix all types in both crates with CIP25/CIP36 to help with this.