MultiEraBlock::from_explicit_network_cbor_bytes EBB #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the function to handle Byron EBBs. We still need to figure out what to do in the general deserialize case #317 or if that behavior should just merge this function in there.
|
Can we also add the inline comment to the hash function in this PR (or do it in a separate PR)? |
rooooooooob
force-pushed
the
multi-era-block-network-tag-ebb
branch
from
46c5120 to
1c9f2fe
Compare
SebastienGllmt
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the function to handle Byron EBBs.
We still need to figure out what to do in the general deserialize case #317 or if that behavior should just merge this function in there.
This works in the meantime and the behavior here would work regardless of how we update
ByronBlock::deserialize()