conway governance tasks #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecioppettini
force-pushed
the
enzo/conway-tasks
branch
from
0dfde3b to
945a2a8
Compare
@ecioppettini hopefully dcSpark/cardano-multiplatform-lib#324 will fix it. I'll test out syncing sancho later after I update multi-era (soon). |
ecioppettini
commented
Apr 5, 2024
| MultiEraCertificate::PoolRegistration(registration) => { | ||
| let operator_credential = registration.pool_params.operator.to_raw_bytes().to_vec(); | ||
| let operator_credential = |
There was a problem hiding this comment.
this is unrelated, but I think this was incorrect, and it was incorrectly ported in the pallas to cml migration.
SebastienGllmt
approved these changes
May 1, 2024
SebastienGllmt
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the most part this can be reviewed, although I probably will do some renames and small changes. BUT the tasks are not tested yet. Mostly because current version of cml parsing fails at an early block in sancho. I have tested the endpoints with mocked data in the tables, and also tested that this doesn't break in preview, but ideally I'd like to test the tasks with actual certificates.