Merge pull request #849 from dcSpark/feature/skip-unsafe

skip unsafe tool
dcSpark · Feb 5, 2025 · b995c8c · b995c8c
2 parents 0f74161 + 92055e4
commit b995c8c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/shinkai-bin/shinkai-node/src/llm_provider/execution/chains/generic_chain/generic_prompts.rs b/shinkai-bin/shinkai-node/src/llm_provider/execution/chains/generic_chain/generic_prompts.rs
@@ -71,6 +71,11 @@ impl JobPromptGenerator {
                                     }
                                 }
                             }
+                            // Skip adding TypeScript unsafe processor tool
+                            // This tool is not supported in Gemini due to undefined function parameters Object
+                            if tool_router_key == "local:::__official_shinkai:::shinkai_typescript_unsafe_processor" {
+                                continue;
+                            }
                         }
                         None => {}
                     }

diff --git a/shinkai-libs/shinkai-sqlite/src/embedding_function.rs b/shinkai-libs/shinkai-sqlite/src/embedding_function.rs
@@ -27,6 +27,7 @@ impl EmbeddingFunction {
         let model_str = match &self.model_type {
             EmbeddingModelType::OllamaTextEmbeddingsInference(model) => model.to_string(),
             _ => {
+                println!("Unsupported embedding model type: {:?}", self.model_type);
                 return Err(rusqlite::Error::InvalidQuery);
             }
         };
@@ -55,11 +56,17 @@ impl EmbeddingFunction {
             .json(&request_body)
             .send()
             .await
-            .map_err(|_e| rusqlite::Error::InvalidQuery)?
+            .map_err(|e| {
+                println!("Failed to send request to embedding API: {}", e);
+                rusqlite::Error::InvalidQuery
+            })?
             .json::<OllamaResponse>()
             .await
-            .map_err(|_e| rusqlite::Error::InvalidQuery)?;
+            .map_err(|e| {
+                println!("Failed to parse embedding API response: {}", e);
+                rusqlite::Error::InvalidQuery
+            })?;
 
         Ok(response.embedding)
     }
-} 
+}