serialization and interface improvements

dcarbone · Apr 15, 2024 · 15576c4 · 15576c4
1 parent 237d3da
commit 15576c4
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 41 deletions.
diff --git a/src/Definition/Type.php b/src/Definition/Type.php
@@ -726,7 +726,7 @@ public function getDirectlyImplementedInterfaces(): array
             }
             if ($this->isContainedType()) {
                 $interfaces[] = PHPFHIR_INTERFACE_CONTAINED_TYPE;
-            } else if ($this->getKind() !== TypeKind::PRIMITIVE) {
+            } else {
                 $interfaces[] = PHPFHIR_INTERFACE_TYPE;
             }
         } elseif ($this->isContainedType() && !$parentType->isContainedType()) {
@@ -749,10 +749,7 @@ public function getDirectlyUsedTraits(): array
             }
             $traits[] = PHPFHIR_TRAIT_VALIDATION_ASSERTIONS;
             $traits[] = PHPFHIR_TRAIT_CHANGE_TRACKING;
-
-            if ($this->getKind() !== TypeKind::PRIMITIVE) {
-                $traits[] = PHPFHIR_TRAIT_XMLNS;
-            }
+            $traits[] = PHPFHIR_TRAIT_XMLNS;
         }
 
         return $traits;

diff --git a/template/interfaces/phpfhir_type.php b/template/interfaces/phpfhir_type.php
@@ -42,11 +42,6 @@
 
  */
 interface <?php echo PHPFHIR_INTERFACE_TYPE; ?> extends \JsonSerializable {
-    /**
-     * @param array|null $data
-     */
-    public function __construct(?array $data = null);
-
     /**
      * Returns the FHIR name represented by this Type
      * @return string

diff --git a/template/types/serialization/json/default.php b/template/types/serialization/json/default.php
@@ -26,7 +26,7 @@
     /**
      * @return \stdClass
      */
-    public function jsonSerialize()
+    public function jsonSerialize(): \stdClass
     {
 <?php if (null !== $type->getParentType()) : ?>
         $out = parent::jsonSerialize();

diff --git a/template/types/serialization/json/list.php b/template/types/serialization/json/list.php
diff --git a/template/types/serialization/json/primitive.php b/template/types/serialization/json/primitive.php
@@ -28,7 +28,7 @@
      * @return <?php echo TypeHintUtils::primitivePHPValueTypeDoc($config, $type->getPrimitiveType(), true, false); ?>
 
      */
-    public function jsonSerialize()
+    public function jsonSerialize(): <?php echo TypeHintUtils::primitivePHPValueTypeDoc($config, $type->getPrimitiveType(), true, false); ?>
     {
 <?php if ($typeKind === TypeKind::PRIMITIVE && str_contains($type->getFHIRName(), 'unsigned')) : ?>
         return intval($this->getValue(), 10);

diff --git a/template/types/serialization/json/resource_container.php b/template/types/serialization/json/resource_container.php
@@ -20,9 +20,9 @@
 
 ob_start(); ?>
     /**
-     * @return object|null
+     * @return null|object
      */
-    public function jsonSerialize()
+    public function jsonSerialize(): null|object
     {<?php foreach($properties as $property) : ?>
 
         if (null !== ($v = $this->get<?php echo ucfirst($property->getName()); ?>())) {