ensuring all local fields are xml serialized (#106)

dcarbone · Apr 30, 2024 · f83de21 · f83de21
1 parent 0397c4b
commit f83de21
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/template/types/serialization/xml.php b/template/types/serialization/xml.php
@@ -71,7 +71,6 @@
     );
 } else {
     // everything else shares a common header
-    // header is always output as it is what creates the simplexml instance
     echo require_with(
             PHPFHIR_TEMPLATE_TYPES_SERIALIZATION_DIR . DIRECTORY_SEPARATOR . 'xml' . DIRECTORY_SEPARATOR . 'serialize' . DIRECTORY_SEPARATOR . 'header.php',
         [

diff --git a/template/types/serialization/xml/serialize/body.php b/template/types/serialization/xml/serialize/body.php
@@ -31,7 +31,7 @@
                 'property' => $property,
             ]
         );
-    } elseif (null === $parentType) {
+    } elseif (0 < count($localProperties)) {
         echo require_with(
             __DIR__ . DIRECTORY_SEPARATOR . 'body_untyped.php',
             [

diff --git a/template/types/serialization/xml/serialize/header.php b/template/types/serialization/xml/serialize/header.php
@@ -31,7 +31,7 @@
     /**
      * @param null|\DOMElement $element
      * @param null|int|\<?php echo ('' === $namespace ? '' : "{$namespace}\\") . PHPFHIR_INTERFACE_XML_SERIALIZALE_CONFIG; ?> $config XML serialization config.  Supports an integer value interpreted as libxml opts for backwards compatibility.
-     * @return \DOMElement<?php if ($typeKind !== TypeKind::PRIMITIVE) : ?>
+     * @return \DOMElement<?php if ($typeKind !== TypeKind::PRIMITIVE || $type->hasParent()) : ?>
 
      * @throws \DOMException<?php endif; ?>