Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation & Url #93

Open
philipbaginski opened this issue Oct 23, 2023 · 4 comments · May be fixed by #96
Open

Translation & Url #93

philipbaginski opened this issue Oct 23, 2023 · 4 comments · May be fixed by #96

Comments

@philipbaginski
Copy link

First of all, greate package, as always :-) Thank you for it. I found few things, I would like to ask to check:

  1. Translations. How to translate Filters and Reset filters?
  2. I would like to add a link into menu to navigate to the resource with applied some of the filter or filters, but right now url never shows applied filter of filters, because filters are deattached from toolbox and added into card, and url only shows url to resource and never change.
@milewski
Copy link
Member

It uses the same translation as nova, so if you have a key Filters and Reset filters filters in your lang.json file it should work

  1. Can you show a screenshot? I'm not following...

@philipbaginski
Copy link
Author

When filters are in standard place, and you applied one of them, the url of the resource change. When filters are inside MegaFilter, the url of the resource does not change. I need url with applied filters.

@milewski
Copy link
Member

milewski commented Oct 23, 2023

Got it, the url does change... I suspect you might have another package that might be interfering with it... can you show me your composer.json so I can try to identify which one is causing the problem

@philipbaginski
Copy link
Author

  1. Regarding translations - my mistake, I added translation and it works. Thank you.

  2. Regarding url:

    Without MegaFilter added into filters[] url with filter applied looks like: http://127.0.0.1:8000/nova/resources/users?users_page=1&users_filter=W3siQXBwXFxOb3ZhXFxGaWx0ZXJzXFxVc2VyVHlwZSI6IjEifV0%3D

    With MegaFilter added into filters[] url with filter applied looks like: http://127.0.0.1:8000/nova/resources/users

composer.json:
mega

@hello-liang-shan hello-liang-shan linked a pull request Feb 1, 2024 that will close this issue
@milewski milewski linked a pull request Feb 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants