-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the compatibility issues with nova v4.32+ #96
base: main
Are you sure you want to change the base?
Conversation
Having 2 mega filters stopped to work... |
Now some filters are gone... for example SliderFilter is not being rendered anymore... |
Wait @hello-liang-shan actually it was not multiple mega filter it was 1 nova dashboard filters + mega filter .. because they looks exactly the same I forgot about it, But I think it is fine only allowing 1 mega filter to be used.. It would mess too much with the store supporting multiple |
now multiple mega filters is supported. I think it's useful to support multiple, especially when there are a lot of filters. |
Try to use the slider filter.. it is not showing on this version... |
This is what I have: MegaFilter::make([
FavoriteColor::make('Color 3')->wrapMode()->noneLabel('Any'),
UserType::make(),
LikesFilter::make('Slider 1')->single(10, 500),
]), It Renders like this: if I duplicate it: MegaFilter::make([
FavoriteColor::make('Color 3')->wrapMode()->noneLabel('Any'),
UserType::make(),
LikesFilter::make('Slider 1')->single(10, 500),
]),
MegaFilter::make([
FavoriteColor::make('Color 3')->wrapMode()->noneLabel('Any'),
UserType::make(),
LikesFilter::make('Slider 1')->single(10, 500),
]), It renders like this: And If I change the filter on the MegaFilter 1 .. it also affects the mega filter 2... But if I rollback to the previous version: |
No description provided.