Skip to content

Commit

Permalink
Fix missing flows in ls_in_dhcp_options table
Browse files Browse the repository at this point in the history
When ha-chassis-group is updated, causing a new hv to become master,
port move to a different chassis, and flows get created in table ls_in_dhcp_options.
If pb->chassis is reported empty by sb (because set to [] by the hv being the
previous owner of the port) those flows were deleted.
However, when pb->chassis is finally updated by sb (to the new hv), flows were
not re-installed, as runtime_data was not seen as updated.

This caused some random failures in test "external logical port".

Signed-off-by: Xavier Simonart <[email protected]>
Acked-by: Mark Michelson <[email protected]>
Signed-off-by: Dumitru Ceara <[email protected]>
(cherry picked from commit 1d22b96)
  • Loading branch information
simonartxavier authored and dceara committed Oct 9, 2023
1 parent e75e2d6 commit 8f7003d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions controller/binding.c
Original file line number Diff line number Diff line change
Expand Up @@ -1311,6 +1311,7 @@ claim_lport(const struct sbrec_port_binding *pb,
register_claim_timestamp(pb->logical_port, now);
sset_find_and_delete(postponed_ports, pb->logical_port);
} else {
update_tracked = true;
if (!notify_up) {
if (!claimed_lport_set_up(pb, parent_pb, sb_readonly)) {
return false;
Expand Down

0 comments on commit 8f7003d

Please sign in to comment.