overlay point support and other improvements and fixes #1
Conversation
Added floorplan.maxZoom() getter/setter, for modifying the depth you could zoom in. Fixed project name in build.xml Recompiled min.js
|
If you accept it, I'll handled adding to the API wiki page. |
floorplan - added layersWidth() assignment to make map tools window bigger overlay - added support for standalone points overlay - fixed bug in select callback overlay - added dragging logic for click versus drag rebuilt min.js
|
floorplan - added layersWidth() assignment to make map tools window |
AndrewArace
changed the title
Changed date-based id scheme to contain internal identifier to allow for multiple instances of same layer types (multiple image layers, for example) Added visible() function to layer definition to change initial state of layer visibility on stage load
|
Thank you for the contributions. I like all the changes you made. Although in the addition of the point support it appears you may have changed the display of the polygons when not in editMode. Originally if editMode is off the polygons would render without the points but I think that is not the case now. I apologize if I'm incorrect, but I didn't have time to test that theory out so I'm only going on code inspection at this point. If you don't get to it before I do I'll confirm if that is the case and patch it when I accept your pull request. |
|
Hi, |
|
I have merged this to my fork. Thank. Sorry for chiming in 2018. 😆 |
|
Hah! no worries, don't even work at that job any more.
…On Tue, Feb 6, 2018, 12:49 PM Nash Gadre ***@***.***> wrote:
I have merged this to my fork. Thank. Sorry for chiming in 2018. 😆
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKQDaf9reeQ8yw14U04BMyPKC5Oj8yzks5tSJCkgaJpZM4EGPR4>
.
|
|
@AndrewArace check this out. I redid parts of it remove layering. Created some dynamic components. |
|
the stupid part was d3 v4 API differences. |
Added floorplan.maxZoom() getter/setter, for modifying the depth you
could zoom in (i was using large detailed SVG backdrops for the imageLayer)
Fixed project name in build.xml (I don't know what "position-analytics" was, but I assume it was a copy-paste typo from another project)
Recompiled min.js
(sorry for the tabs/spaces diffs)