fix prefetch related with UUID fields #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the foreign key is stored as a string (char field) and the uuid field is returned as a UUID (StringUUID) object, prefetch related does not work. This patch makes StringUUID dict keys equivelent to string dict keys.
|
This fixes the prefetch related issue and does not break existing code since the .hex method can still be called on the StringUUID object. |
ydaniv
added a commit
to ydaniv/django-uuidfield
that referenced
this pull request
Oct 1, 2014
|
Looks good to me. Any concerns, @dcramer? |
|
The fix is not working when you are using |
sshishov
reviewed
Feb 24, 2021
Comment on lines
+37
to
+41
| def __hash__(self): | ||
| return self.__unicode__().__hash__() | ||
|
|
||
| def __eq__(self, other): | ||
| return self.__unicode__().__eq__(unicode(other).replace('-', '')) |
There was a problem hiding this comment.
Suggested change
| def __hash__(self): | |
| return self.__unicode__().__hash__() | |
| def __eq__(self, other): | |
| return self.__unicode__().__eq__(unicode(other).replace('-', '')) | |
| def __hash__(self): | |
| return self.__unicode__().replace('-', '').__hash__() | |
| def __eq__(self, other): | |
| return self.__unicode__().replace('-', '').__eq__(unicode(other).replace('-', '')) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the foreign key is stored as a string (char field) and
the uuid field is returned as a UUID (StringUUID) object, prefetch
related does not work.
This patch makes StringUUID dict keys equivelent to string dict
keys.