Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add magic link auth #225

Merged
merged 16 commits into from
Oct 8, 2024
Merged

Add magic link auth #225

merged 16 commits into from
Oct 8, 2024

Conversation

dcramer
Copy link
Owner

@dcramer dcramer commented Oct 2, 2024

Still some work to do here to make the flow have the user experience I want.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 70.89947% with 55 lines in your changes missing coverage. Please review.

Project coverage is 75.40%. Comparing base (fd91ffa) to head (ef17c35).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/server/src/lib/email.ts 20.45% 35 Missing ⚠️
apps/server/src/lib/auth.ts 5.88% 16 Missing ⚠️
...pps/server/src/trpc/routes/authMagicLinkConfirm.ts 95.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
- Coverage   75.62%   75.40%   -0.23%     
==========================================
  Files         300      303       +3     
  Lines       17882    18051     +169     
  Branches     1937     1950      +13     
==========================================
+ Hits        13524    13611      +87     
- Misses       4358     4440      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dcramer dcramer marked this pull request as ready for review October 8, 2024 16:02
@dcramer dcramer merged commit ee8ff9f into main Oct 8, 2024
6 checks passed
@dcramer dcramer deleted the feat/magic-links branch October 8, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant