-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype of new Device and Exposes Design #25
Draft
ddellacosta
wants to merge
17
commits into
main
Choose a base branch
from
device-messaging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…make implementing the wrapper that can support other device types (Matter) simpler. Test scaffolding in place and first pass at basic Exposes structure implemented.
…scaffolding, but tests are pending
… basic Device parsing works. DeviceView just dumping output of `show exposes` for now. TODO implement full Device parsing, new Device components for view
…xposes -- reintroduced Capability as a name for any given Exposes value; added lenses to access Device and Capability properties; moved tests inside of `Test` folder to be consistent with `src` layout
ddellacosta
changed the title
Prototype of new Device and Exposes construction
Prototype of new Device and Exposes Design
Mar 30, 2024
…ned by specific types and added a very basic Device-type-specific view for the new types
…ed UI components back in to DeviceView now that it's possible to dispatch on device type, specifically lighting sub-types
…eviously commented out UI code in DeviceView is now all accounted for--it's now a prototype of a more mobile-facing UI
…tend and backend; fixes issue with tests breaking due to react-bootstrap module import failing; introduces groups to frontend and abstracts devices and groups into resources; adds bootstrap-5.3.2 since I guess I didn't do that yet; probably more I forgot since this is ridiculous
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to produce a new Design for Devices and their capabilities on the frontend. The output of this PR should be at least a single "Matter-like" Device which abstracts details of Matter vs. Zigbee2MQTT so that Devices all present the same interface for use elsewhere in the app. This will also include an updated parsing approach to Zigbee2MQTT exposes data in particular, so that it is more flexible and easier to work with without losing type safety.
I am imagining that this will be followed by a bunch of small PRs for each Device type that is relevant for me, adapted from the Matter 1.2 device spec. This will probably be primarily lights and sensors for the time being.
TODO: