Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ddev add-on command #29

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

tyler36
Copy link
Collaborator

@tyler36 tyler36 commented Oct 25, 2024

The Issue

ddev get was deprecated in v1.23.5.

How This PR Solves The Issue

This PR updates the tests to use the ddev add-on command.

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, and as the PR title says, https://github.com/ddev/ddev-adminer/blob/main/tests/test.bats needs an update, right?

@tyler36 tyler36 force-pushed the 20240604-bump-github-action-add-on-test branch from 931444a to 5696776 Compare October 27, 2024 23:56
@tyler36
Copy link
Collaborator Author

tyler36 commented Oct 27, 2024

Sorry, my bad.

Fixed PR.

@tyler36 tyler36 requested a review from stasadev October 27, 2024 23:58
Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stasadev stasadev merged commit 38e0b97 into ddev:main Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants