-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve $PLATFORM_ROUTES to include at least route id and multiple routes, for #95, followup to #47 #103
Conversation
d0dd8a6
to
5f65b65
Compare
To test this, |
Current DDEV is OK with a non-existent routes.yaml |
bfc38a3
to
666dd67
Compare
1a37704
to
585090e
Compare
I think this is getting the routes right now! |
@gilzow if you could take it for a spin,
Mostly just validate the $PLATFORM_ROUTES that you find in the container, etc. |
woooooohhhhoooooo!!!!!!
Inside the app?
💪 |
Improve actual support for PLATFORM_ROUTES #47
Magento2 doesn't work with add-on: "Cannot find the main route for Magento. Please add
id: magento_route
to your routes.yaml" #95PLATFORM_ROUTES was previously just one static route. Now it's generated from .platform/routes.yaml. Not all features are relevant or supported.
This adds redis-persistent as a service, since that's what the magento2ce template requires.
Adds a drupal9 database load for better testing of drupal9
This does not yet get magento2ce to completion. More work is required. I'll need help. I'm not sure the template is actually using $PLATFORM_ROUTES correctly, as it still tries to connect to
redis.internal
even when $PLATFORM_ROUTES is properly filled out.