Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use p3m and pak to R package binary installation #34

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Apr 28, 2024

I believe that binary installations can improve the speed of CI.

@eitsupi eitsupi marked this pull request as ready for review April 28, 2024 12:48
@eitsupi
Copy link
Contributor Author

eitsupi commented Apr 28, 2024

The CI run time appears to have been reduced from 1 hour to 6 minutes.

Copy link
Owner

@ddotta ddotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @eitsupi for your PR !
I saw that you and etienne have now become the 2 main contributors to the R polars package!

You're really doing a great job and I'd love to be able to find the time to add the latest additions to this cookbook, but I just don't have enough time :(

@ddotta ddotta merged commit 4c45887 into ddotta:main Apr 29, 2024
1 check passed
@eitsupi eitsupi deleted the ci branch April 29, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants