Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3 methods for sorting & filtering hierarchical tables #2097

Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
ee4214a
Add sorting function
edelarua Dec 6, 2024
a9e19ec
Clean up documentation
edelarua Dec 6, 2024
08e2e7e
Merge branch 'main' into 767_sort_hierarchical
edelarua Dec 6, 2024
1585a63
Add filtering function
edelarua Dec 6, 2024
6c28907
Clean up
edelarua Dec 6, 2024
4272499
Document
edelarua Dec 6, 2024
f02c7c5
Improve code
edelarua Dec 7, 2024
30c574b
Fix checks
edelarua Dec 7, 2024
7103b59
Add tests for sorting
edelarua Dec 7, 2024
d82c06f
Add filtering tests
edelarua Dec 9, 2024
cd484f6
Fix test
edelarua Dec 9, 2024
4d1a4bf
Merge branch 'main' into 767_sort_filter_hierarchical
ddsjoberg Dec 18, 2024
48d2258
Merge branch 'main' into 767_sort_filter_hierarchical
ddsjoberg Dec 23, 2024
e857746
Merge branch 'main' into 767_sort_filter_hierarchical
ddsjoberg Dec 29, 2024
ae03a80
Merge branch 'main' into 767_sort_filter_hierarchical
ddsjoberg Jan 6, 2025
5f9f63c
Merge branch 'main' into 767_sort_filter_hierarchical
ddsjoberg Jan 7, 2025
2c9638e
Merge branch 'main' into 767_sort_filter_hierarchical
edelarua Jan 27, 2025
0fa9fe8
Update sort parameters
edelarua Jan 29, 2025
86b9898
testing
edelarua Feb 13, 2025
cd20410
Finish sort function, update tests
edelarua Feb 13, 2025
1b46407
I think this is not supposed to be missing?
edelarua Feb 13, 2025
97869ac
Merge branch 'main' into 767_sort_filter_hierarchical
edelarua Feb 13, 2025
d7ccb18
Move sorting
edelarua Feb 13, 2025
db75c33
testing
edelarua Feb 13, 2025
34aca10
Rename
edelarua Feb 13, 2025
dfa61bd
test
edelarua Feb 14, 2025
a9d9f19
Sort using x$table_body
edelarua Feb 14, 2025
07646b7
temp
edelarua Feb 14, 2025
8708969
Merge branch 'main' into 767_sort_filter_hierarchical
edelarua Feb 18, 2025
0168a6d
Fix filtering function, add parameter
edelarua Feb 19, 2025
73861f1
Update tests
edelarua Feb 19, 2025
396f5c6
Merge branch 'main' into 767_sort_filter_hierarchical
edelarua Feb 19, 2025
a9737e4
Fix checks
edelarua Feb 19, 2025
ae322a1
Add to author list
edelarua Feb 19, 2025
b8bac66
Add test
edelarua Feb 19, 2025
4838772
Rename cards functions
edelarua Feb 28, 2025
7009599
Merge branch 'main' into 767_sort_filter_hierarchical
edelarua Feb 28, 2025
ab0f892
Account for overall column in tbl_filter
edelarua Mar 4, 2025
8c25b6e
Merge branch 'main' into 767_sort_filter_hierarchical
edelarua Mar 4, 2025
14204ef
Account for overall column in tbl_sort
edelarua Mar 4, 2025
172481d
Update docs
edelarua Mar 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test
edelarua committed Dec 9, 2024
commit cd484f6faaab2c6e9171fc98359f1bbdaa580f9a
2 changes: 1 addition & 1 deletion tests/testthat/test-filter_tbl_hierarchical.R
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ test_that("tbl_filter.tbl_hierarchical(gt) works", {
expect_silent(tbl_gt <- tbl_filter(tbl, t = 10))

# gt = FALSE
expect_silent(tbl_lt <- tbl_filter(tbl, t = 10, gt = FALSE))
expect_message(tbl_lt <- tbl_filter(tbl, t = 10, gt = FALSE))

expect_equal(
dplyr::inner_join(