Fix/tests on macos (#2498)

* fix(E2E): Adjust config for testing on macOS * adjusted troubleshooting readme Co-authored-by: denbicloud <[email protected]>
deNBI · Jan 26, 2021 · 5a0d836 · 5a0d836
1 parent 5ce93a2
commit 5a0d836
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/e2e/protractor.conf.js b/e2e/protractor.conf.js
@@ -52,7 +52,7 @@ exports.config = {
       args: ["--incognito"]
     }
   },
-  directConnect: true,
+  directConnect: true, //uncomment on macOS, also start webserver via webdriver-manager
   framework: 'jasmine',
   jasmineNodeOpts: {
     showColors: true,

diff --git a/troubleshooting/README.md b/troubleshooting/README.md
@@ -15,3 +15,4 @@ Try running `make new_env_and_nodes`, pinning the chromedriver version in packag
 
 ##### Some solutions regarding testing
 - Do you have an environment.json in your e2e folder? It needs to be filled with login information and the url. Portal key is the url to the portal login, i.e. localhost:8000 or https://staging-url.de/portal, angular is the url to the angular pages, without the #, i.e. localhost:8001 or https://staging-url.de/portal/webapp.
+- Problems on **macOS**: In some cases, the test process does not run properly under macOS. The `directConnect: true` parameter is often the cause of problems. One solution is to comment out this parameter from the config. Running the [webdriver-manager](https://www.npmjs.com/package/webdriver-manager/) with `webriver-manager update` and `webdriver-manager start` before `ng e2e` is then necessary.
Original file line number	Diff line number	Diff line change
Expand Up		@@ -15,3 +15,4 @@ Try running `make new_env_and_nodes`, pinning the chromedriver version in packag

		##### Some solutions regarding testing
		- Do you have an environment.json in your e2e folder? It needs to be filled with login information and the url. Portal key is the url to the portal login, i.e. localhost:8000 or https://staging-url.de/portal, angular is the url to the angular pages, without the #, i.e. localhost:8001 or https://staging-url.de/portal/webapp.
		- Problems on macOS: In some cases, the test process does not run properly under macOS. The `directConnect: true` parameter is often the cause of problems. One solution is to comment out this parameter from the config. Running the [webdriver-manager](https://www.npmjs.com/package/webdriver-manager/) with `webriver-manager update` and `webdriver-manager start` before `ng e2e` is then necessary.