bibtool: added year to citekey #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcfehling
commented
Sep 13, 2022
Comment on lines
+573
to
+574
| year = 2015, | ||
| month = nov, |
There was a problem hiding this comment.
The conference happened in Nov 15, but the article was first published online Mar 2016.
There was a problem hiding this comment.
As a general rule, please do one thing at a time. It's impossible to look through thousands of lines of changes that are automatically generated if you're also making semantic changes. If you need to make a change like this, do it in a separate patch.
There was a problem hiding this comment.
It's in the second commit. I can easily turn it into a separate PR if you like.
Comment on lines
23
to
24
| year = 2017, | ||
| month = aug, |
There was a problem hiding this comment.
Here and for the following: The journals have been published in 2018, but they have been online already in 2017.
bangerth
approved these changes
Sep 13, 2022
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #389. This should fix part 2 of #405.
I've changed the citekey that in starts with the year.
The nice thing about this approach is that the publications are now also sorted by year first, which lets us easily identify articles that are in the wrong file. I moved some articles around in the second commit and found a few duplicates.