Fix issue deanmalmgren#342 #422
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarification, _getStringStream *should* return `unicode` in Python 2, `str` in Python 3, IF the stream requested exists. If it does not exist, it returns `None`, which cannot be added to bytes. This commit adds a check for None, returning an empty bytes string if matched.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a fix for issue #342 caused by
extract_msg.Message._getStringStreamreturningNonefor streams that are not found in the MSG file (this is intentional and should be handled accordingly).ensure_bytesnow checks forNoneand returns an empty bytes string when found.Additionally, updated the naming used in the documentation to match the current naming.
Also, for clarification,
extract_msg.Message._getStringStreamshould only ever be returningunicodeon Python 2 andstron Python 3. If this is not the case, that is a bug that should be reported.(By the way, contributing guidelines say to use issue2pr for existing issues, but I couldn't get it to work at all.)