Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change 'sudo' to 'become' to fix deprecated warnings #50

Closed
wants to merge 1 commit into from
Closed

change 'sudo' to 'become' to fix deprecated warnings #50

wants to merge 1 commit into from

Conversation

cultcom
Copy link

@cultcom cultcom commented Aug 11, 2016

No description provided.

@ypid
Copy link
Member

ypid commented Aug 11, 2016

@cultcom Hey, I would be interested how you automated this 😉

Please note that such DebOps wide replacements should be discussed first.

@ypid
Copy link
Member

ypid commented Aug 11, 2016

@ypid ypid closed this Aug 11, 2016
@cultcom
Copy link
Author

cultcom commented Aug 11, 2016

@ypid: there are two options I found for automation:

  1. git-hub package on ubuntu/mint
    a python script which initializes an API key and uses it for such things
  2. https://github.com/github/hub
    a kind of official binary warping arround "git" to add github subcommands.

And yes, I am stupid and did not read the travis docs beforehand, sorry for that, I revert the changes on those files and try it again tomorrow.
That will reduce the involved repositories a lot.

@ypid
Copy link
Member

ypid commented Aug 11, 2016

And yes, I am stupid and did not read the travis docs beforehand, sorry for that, I revert the changes on those files and try it again tomorrow.
That will reduce the involved repositories a lot.

Can you please talk with us before you do that? Either on IRC or in this PR. We review all patches and then merge them locally. Check: https://docs.debops.org/en/latest/debops-policy/docs/code-signing-policy.html
So doing this causes a certain overhead.

I take the approach to run a few rewrite rules using sphinx-optimize against the repositories when I fix typos or so on anyway.

Believe me, I sometimes would like to achieve a similar thing then you did with your patch series. Just automatically fix an issue and then automatically open PR for each repo. For the one who is doing that it does not matter if there are 100 or 1000 repos but for the maintainers on the other side it does matter. Also, we could do such global operations more easily anyway. But our current workflow is not yet setup for doing something like this also because we review all changes before they enter the main repos.

Related to: debops/debops-tools#128
Related to: debops/debops-tools#120
Related to: debops/debops-tools#163

there are two options I found for automation:

And how did you do your first patch series? Manually? 😄 Remember that we are an automation project 😉

@cultcom
Copy link
Author

cultcom commented Aug 12, 2016

@ypid: semi manually, I grep'ed for sudo: and sudo_user: and checked all the results manually before I changed the occasions by sed and vim depending on the file.
The travis files were a severe misunderstanding...

@ypid
Copy link
Member

ypid commented Aug 12, 2016

And the forking of the repos on github and opening the PRs 😉 ?

@cultcom
Copy link
Author

cultcom commented Aug 12, 2016

@ypid: yes, that is where I used the "git-hub" script. Just a bash "for" loop and "git-hub clone" and it forks the upstream to your own account. It can also automatically create PRs for you using the official github API. Very handsome.

@cultcom cultcom deleted the fix_deprecated branch April 7, 2017 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants