Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename owncloud__theme_entitiy_name to owncloud__theme_entity_name #80

Merged
merged 1 commit into from
Jan 18, 2017

Conversation

jbicha
Copy link
Contributor

@jbicha jbicha commented Jan 18, 2017

Typo fix. Should we allow the old variable name to not break existing configurations?

Copy link
Member

@ypid ypid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ypid ypid merged commit 3a6ec66 into debops:master Jan 18, 2017
ypid added a commit that referenced this pull request Jan 18, 2017
ypid added a commit that referenced this pull request Jan 18, 2017
ypid added a commit that referenced this pull request Jan 18, 2017
@ypid
Copy link
Member

ypid commented Jan 18, 2017

We usually do hard breaks as DebOps is still in 0.x version areas. I added your change to the changelog and the upgrade script to make it easier for users to upgrade (ref: debops/docs#160). You can check the commits which are linked to this PR for details. Thanks again for spotting this typo 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants