Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always_run is deprecated #20

Merged
merged 1 commit into from
Jan 9, 2017
Merged

always_run is deprecated #20

merged 1 commit into from
Jan 9, 2017

Conversation

carlalexander
Copy link
Contributor

Replaced with new check_mode variable.

@drybjed drybjed merged commit cafda8d into debops:master Jan 9, 2017
@carlalexander carlalexander deleted the patch-1 branch January 16, 2017 13:43
@ypid
Copy link
Member

ypid commented Jan 18, 2017

@carlalexander What about min_ansible_version: '2.0.0' in meta/main.yml? Ref: debops/ansible-owncloud#77 (comment)

@carlalexander
Copy link
Contributor Author

I honestly didn't think it would break outside 2.0.0. I'd revert the change.

@ypid
Copy link
Member

ypid commented Jan 18, 2017

You are right. That is a bit unfortunate but at least the docs are clear about it: Enabling or disabling check mode for tasks 😉

@muelli
Copy link

muelli commented Feb 1, 2017

hrm. If check_mode is used, then ansible 2.2 needs to be used. IOW: It's not compatible with Ansible 2.0. So either this change needs to be reverted or meta/main.yml needs to list 2.2 as requirement. That would, however, break the currently stable Ubuntu as it ships 2.0.0.2.

When will ansible pull the always_run flag?

ypid added a commit to ypid/ansible-php that referenced this pull request Feb 1, 2017
This reverts commit cafda8d.

As discussed debops#20 we want to
retain computability with Ansible 2.1.
@ypid
Copy link
Member

ypid commented Feb 1, 2017

@muelli Hi, I have just been looking into this because it was still unfixed.

About Ansible 2.0.0.2 and Ubuntu. I just checked and it seems that Ubuntu does not have real security support for Ansible as you can see.

Ref: http://packages.ubuntu.com/search?suite=zesty&searchon=names&keywords=ansible

AFAIK the only supported Ansible versions are 2.1 and 2.2. All previous versions must be expected to have known security vulnerability and must not be used anymore. Please install Ansible manually on Ubuntu. Debian handles this much better as I expected it 😉

Because of this DebOps will not support Ansible 2.0. Ansible 2.1 support should be retained as discussed.

@muelli
Copy link

muelli commented Feb 1, 2017

fair enough. I guess meta/main.yml still needs to be updated then :)

ypid added a commit to ypid/ansible-php that referenced this pull request Feb 1, 2017
This reverts commit cafda8d.

As discussed debops#20 we want to
retain comparability with Ansible 2.1.
@ypid
Copy link
Member

ypid commented Feb 1, 2017

I think the policy that DebOps only supports Ansible versions which are also supported has not been specified yet in the docs. Also, this is not automated yet to update each and every role in DebOps as soon as Ansible versions drop out of support.

Ref: https://github.com/ypid/ypid-ansible-common/blob/master/bin/ansible-update-min-version
Ref: ansible/ansible#18375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants