Merge pull request #210 from decaf-dev/favorite-fixes

Favorite fixes
decaf-dev · Jul 16, 2024 · b4e55fb · b4e55fb
2 parents 1d2bd71 + 29e2837
commit b4e55fb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/svelte/app/components/grid-card.svelte b/src/svelte/app/components/grid-card.svelte
@@ -204,11 +204,7 @@
 		{/if}
 		{#if isFavorite === true}
 			<div class="vault-explorer-grid-card__favorite">
-				<Icon
-					iconId="star"
-					ariaLabel="Favorite"
-					color="var(--color-yellow)"
-				/>
+				<Icon iconId="star" ariaLabel="Favorite" />
 			</div>
 		{/if}
 	</div>
@@ -235,6 +231,7 @@
 				{#if url !== null}
 					<IconButton
 						iconId="external-link"
+						ariaLabel="Open in browser"
 						noPadding
 						on:click={handleUrlClick}
 					/>

diff --git a/src/svelte/app/index.svelte b/src/svelte/app/index.svelte
@@ -7,7 +7,7 @@
 	import FavoritesFilter from "./components/favorites-filter.svelte";
 	import TabList from "../shared/components/tab-list.svelte";
 	import Tab from "../shared/components/tab.svelte";
-	import { TFile } from "obsidian";
+	import { Notice, TFile } from "obsidian";
 	import {
 		TCustomFilter,
 		TDashboardView,
@@ -703,6 +703,9 @@
 
 		//If the favorite property is not set, return
 		if (favoritePropertyName === "") {
+			new Notice(
+				"Please select a favorite property in the Vault Explorer settings to use this feature",
+			);
 			return;
 		}