Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cumulative emission total on GHG emissions chart #7

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

crantok
Copy link

@crantok crantok commented Jan 14, 2014

I beg your pardon but I didn't know how to submit a merge request for a single file. There is only one file that you might care about in this request, which is:

src/javascripts/primary_energy.js.coffee

All the rest of the changes are just compiled assets which (now that I've tried merging from upstream and submitting this pull request) I think would be better off being excluded from the repo.

The change in question is a refinement of a hack to add cumulative carbon emissions to the GHG emissions chart, made at the recent Manchester hackday (25/11/2013). You can see it in operation here...

http://2050.hellings.webfactional.com

@tamc
Copy link
Member

tamc commented Jan 15, 2014

Thanks @crantok. I'm travelling this week, but I'm looking forward to having a look at this next week.

@crantok
Copy link
Author

crantok commented Jan 29, 2014

Hi @tamc. Did you get a chance to look at the pull request?

@tamc
Copy link
Member

tamc commented Jan 29, 2014

Sorry. Not yet. I was travelling, then ill. Trying hard to catch up with my todo list by the end of the week. Tom

On 29 Jan 2014, at 10:47, Justin Hellings [email protected] wrote:

Hi @tamc. Did you get a chance to look at the pull request?


Reply to this email directly or view it on GitHub.

@crantok
Copy link
Author

crantok commented Jan 30, 2014

Sorry to hear you've been ill, Tom. I hope you manage to catch up without
too much stress. Good luck. Justin

On Wednesday, January 29, 2014, Tom Counsell [email protected]
wrote:

Sorry. Not yet. I was travelling, then ill. Trying hard to catch up with
my todo list by the end of the week. Tom

On 29 Jan 2014, at 10:47, Justin Hellings <[email protected]javascript:_e(%7B%7D,'cvml','[email protected]');>
wrote:

Hi @tamc. Did you get a chance to look at the pull request?

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHubhttps://github.com//pull/7#issuecomment-33605089
.

@tamc
Copy link
Member

tamc commented Apr 4, 2014

Hi @crantok

I've had a look at this. I think the idea is good. But I wonder if it might be better to implement the cumulative calculation in the excel rather than the javascript. I'll have a look.

Best wishes

Tom

@crantok
Copy link
Author

crantok commented Apr 4, 2014

Hi Tom,

Thanks for checking this out.

That's a really good point about putting the calculation in the
spreadsheet. I'd not thought about it but, of course, it means quicker
feedback for people hacking the spreadsheet.

Justin

On Friday, April 4, 2014, Tom Counsell [email protected] wrote:

Hi @crantok https://github.com/crantok

I've had a look at this. I think the idea is good. But I wonder if it
might be better to implement the cumulative calculation in the excel rather
than the javascript. I'll have a look.

Best wishes

Tom

Reply to this email directly or view it on GitHubhttps://github.com//pull/7#issuecomment-39609544
.

Justin Hellings, participative web developer
@jhellings http://twitter.com/jhellings

For customers: 3 Mules http://3mules.coop
For geeks: Yak hair surplus http://yakhairsurplus.com
For anyone: Calories per pence http://caloriesperpence.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants