chore: use node18 (#1771)

.github/workflows/build.yml

@@ -41,10 +41,10 @@ jobs:
           - 5432:5432
     steps:
       - uses: actions/checkout@v4
-      - name: Use Node.js 16.16.0
+      - name: Use Node.js 18.x
         uses: actions/setup-node@v4
         with:
-          node-version: 16.16.0
+          node-version: 18.x
           cache: yarn
       - name: install
         run: yarn install --frozen-lockfile
@@ -53,15 +53,14 @@ jobs:
       - name: test
         run: yarn test:content
 
-
   test-lambdas:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - name: Use Node.js 16.16.0
+      - name: Use Node.js 18.x
         uses: actions/setup-node@v3
         with:
-          node-version: 16.16.0
+          node-version: 18.x
           cache: yarn
       - name: install
         run: yarn install --frozen-lockfile

Dockerfile

@@ -1,4 +1,4 @@
-FROM node:16-alpine as base
+FROM node:18-alpine as base
 WORKDIR /app
 RUN apk add --no-cache bash git
 

content/src/Environment.ts

@@ -408,7 +408,7 @@ export class EnvironmentBuilder {
       EnvironmentConfig.CONTENT_SERVER_ADDRESS,
       () =>
         process.env.CONTENT_SERVER_ADDRESS ||
-        'http://localhost:' + env.getConfig<number>(EnvironmentConfig.HTTP_SERVER_PORT).toString()
+        'http://127.0.0.1:' + env.getConfig<number>(EnvironmentConfig.HTTP_SERVER_PORT).toString()
     )
 
     this.registerConfigIfNotAlreadySet(

content/src/components.ts

@@ -330,13 +330,15 @@ export async function initComponentsWithEnv(env: Environment): Promise<AppCompon
   let started = false
   const server = {
     ..._server,
-    start: async (options) => {
+    start: async (options: any) => {
       started = true
-      return _server.start && _server.start(options)
+      if (_server.start) {
+        await _server.start(options)
+      }
     },
     stop: async () => {
-      if (started) {
-        return _server.stop && _server.stop()
+      if (started && _server.stop) {
+        return _server.stop()
       }
     }
   }

content/src/service/synchronization/retryFailedDeployments.ts

@@ -27,9 +27,6 @@ export const createRetryFailedDeployments = (
 ): IRetryFailedDeploymentsComponent => {
   const retryDelay = components.env.getConfig<number>(EnvironmentConfig.RETRY_FAILED_DEPLOYMENTS_DELAY_TIME)
   const logger = components.logs.getLogger('RetryFailedDeployments')
-  let ac: AbortController | undefined = new AbortController()
-  const signal = ac.signal
-
   let running = false
   return {
     start: async () => {
@@ -38,15 +35,11 @@ export const createRetryFailedDeployments = (
     },
     stop: async () => {
       running = false
-      if (ac) {
-        ac.abort()
-      }
-      ac = undefined
       logger.debug('Stopping retry failed deployments')
     },
     schedule: async () => {
       while (running) {
-        await setTimeout(retryDelay, null, { signal })
+        await setTimeout(retryDelay, null)
         if (!running) {
           return
         }

content/test/integration/E2ETestEnvironment.ts

@@ -149,7 +149,11 @@ export class ServerBuilder {
   private readonly builder: EnvironmentBuilder
   private readonly storageBaseFolder: string
 
-  constructor(private readonly testEnvCalls: TestEnvCalls, env: Environment, public dao: DAOComponent) {
+  constructor(
+    private readonly testEnvCalls: TestEnvCalls,
+    env: Environment,
+    public dao: DAOComponent
+  ) {
     this.builder = new EnvironmentBuilder(env)
     this.storageBaseFolder = env.getConfig(EnvironmentConfig.STORAGE_ROOT_FOLDER) ?? 'storage'
   }
@@ -175,7 +179,7 @@ export class ServerBuilder {
     const servers: TestProgram[] = []
     for (let i = 0; i < ports.length; i++) {
       const port = ports[i]
-      const domain = `http://localhost:${port}`
+      const domain = `http://127.0.0.1:${port}`
       this.testEnvCalls.addToDAO(domain)
       const components = await this.builder
         .withConfig(EnvironmentConfig.HTTP_SERVER_PORT, port)

content/test/integration/TestProgram.ts

@@ -48,7 +48,7 @@ export class TestProgram {
 
   getUrl(): string {
     const port = this.components.env.getConfig(EnvironmentConfig.HTTP_SERVER_PORT)
-    return `http://localhost:${port}`
+    return `http://127.0.0.1:${port}`
   }
 
   async stopProgram(): Promise<void> {

content/test/integration/simpleTestEnvironment.ts

@@ -98,7 +98,7 @@ async function createServer(
     .withConfig(EnvironmentConfig.STORAGE_ROOT_FOLDER, `${storageBaseFolder}/${serverPort}`)
     .buildConfigAndComponents()
 
-  const domain = `http://localhost:${serverPort}`
+  const domain = `http://127.0.0.1:${serverPort}`
   dao.add(domain)
   const server = new TestProgram(components)
   server.components.daoClient = dao