fix: Avoid trying to show non mapped notifications (#191)

* fix: Avoid trying to show non mapped notifications * chore(deps): bump schemas
decentraland · Sep 5, 2024 · 9c8e91a · 9c8e91a
1 parent 701d3e9
commit 9c8e91a
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 18 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -37,7 +37,7 @@
   },
   "homepage": "https://github.com/decentraland/ui2#readme",
   "dependencies": {
-    "@dcl/schemas": "^13.8.6",
+    "@dcl/schemas": "^13.9.0",
     "@dcl/ui-env": "^1.5.1",
     "@emotion/react": "^11.11.4",
     "@emotion/styled": "^11.11.5",

diff --git a/src/components/Notifications/NotificationsFeedTabs.tsx b/src/components/Notifications/NotificationsFeedTabs.tsx
@@ -34,14 +34,17 @@ const NotificationHandler = ({
   renderProfile?: (address: string) => JSX.Element | string | null
 }) => {
   const NotificationComponent = NotificationComponentByType[notification.type]
+
+  if (!NotificationComponent) {
+    return null
+  }
+
   return (
-    NotificationComponent && (
-      <NotificationComponent
-        notification={notification}
-        locale={locale}
-        renderProfile={renderProfile}
-      />
-    )
+    <NotificationComponent
+      notification={notification}
+      locale={locale}
+      renderProfile={renderProfile}
+    />
   )
 }
 

diff --git a/src/components/Notifications/utils.tsx b/src/components/Notifications/utils.tsx
@@ -45,12 +45,12 @@ function getBGColorByRarity(rarity: Rarity) {
   return Rarity.getGradient(rarity).join()
 }
 
-type DecentralandNotificationComponentByType<T> = {
+type DecentralandNotificationComponentByType<T> = Partial<{
   [k in NotificationType]: T extends DCLNotificationProps
     ? // eslint-disable-next-line @typescript-eslint/no-explicit-any
       FunctionComponent<CommonNotificationProps<any>> | null
     : never
-}
+}>
 
 const NotificationComponentByType: DecentralandNotificationComponentByType<DCLNotificationProps> =
   {
@@ -92,10 +92,6 @@ const NotificationComponentByType: DecentralandNotificationComponentByType<DCLNo
       WorldsPermissionGrantedNotification,
     [NotificationType.WORLDS_PERMISSION_REVOKED]:
       WorldsPermissionRevokedNotification,
-    [NotificationType.BADGE_GRANTED]: null,
-    [NotificationType.GOVERNANCE_CLIFF_ENDED]: null,
-    [NotificationType.GOVERNANCE_WHALE_VOTE]: null,
-    [NotificationType.GOVERNANCE_VOTED_ON_BEHALF]: null,
     [NotificationType.REWARD_CAMPAIGN_OUT_OF_FUNDS]:
       CampaignOutOfFundsNotification,
     [NotificationType.REWARD_CAMPAIGN_GAS_PRICE_HIGHER_THAN_EXPECTED]: