Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Navbar component #175

Merged
merged 23 commits into from
Sep 6, 2024
Merged

feat: Navbar component #175

merged 23 commits into from
Sep 6, 2024

Conversation

braianj
Copy link
Collaborator

@braianj braianj commented Aug 15, 2024

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Aug 15, 2024

Deploying ui2 with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9a0d234
Status: ✅  Deploy successful!
Preview URL: https://8d63aa92.ui2-423.pages.dev
Branch Preview URL: https://feat-navbar.ui2-423.pages.dev

View logs

@braianj braianj self-assigned this Aug 16, 2024
@braianj braianj added the enhancement New feature or request label Aug 16, 2024
"& :hover": {
color: theme.palette.text.primary,
},
"@media (max-width: 991px)": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about setting the media sizes as global variables?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/components/Navbar/Navbar.tsx Outdated Show resolved Hide resolved
src/components/Navbar/Navbar.types.ts Outdated Show resolved Hide resolved
@braianj braianj merged commit 8795744 into master Sep 6, 2024
3 checks passed
@braianj braianj deleted the feat/navbar branch September 6, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants